[ASTDumper] Remove hasNonStandardOutput
#81351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionalizing logic based on the exact output stream is brittle since e.g the client may be writing to an intermediate buffer before forwarding onto the output. For the ASTDumper itself, the client already passes whether or not it expects a fully semantic dump, use that instead. For `printContext`, the only client relying on this was some `ResolvedRangeInfo` tests, but these don't actually care about the computed discriminator, adjust the tests to not care.
hamishknight
requested review from
ahoppen,
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
rintaro
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionalizing logic based on the exact output stream is brittle since e.g the client may be writing to an intermediate buffer before forwarding onto the output. For the ASTDumper itself, the client already passes whether or not it expects a fully semantic dump, use that instead. For
printContext, the only client relying on this was someResolvedRangeInfotests, but these don't actually care about the computed discriminator, adjust the tests to not care.